[GPU] Limit sdpa_micro attention mask load to avoid compilation error #31376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
build_jenkins |
p-durandin
reviewed
Jul 18, 2025
src/plugins/intel_gpu/src/kernel_selector/cl_kernels/sdpa_micro.cl
Outdated
Show resolved
Hide resolved
clee30
force-pushed
the
sdpa_micro_attn_mask
branch
from
491976e to
7296cff
Compare
p-durandin
approved these changes
Jul 18, 2025
sshlyapn
reviewed
Jul 18, 2025
clee30
force-pushed
the
sdpa_micro_attn_mask
branch
from
7296cff to
4969e37
Compare
|
build_jenkins |
clee30
force-pushed
the
sdpa_micro_attn_mask
branch
3 times, most recently
from
37277ec to
f9aa9cf
Compare
|
build_jenkins |
clee30
force-pushed
the
sdpa_micro_attn_mask
branch
from
f9aa9cf to
e269209
Compare
|
build_jenkins |
Earlier 3b84486 commit has caused kernel compilation error for shape of [batch, num_heads, 1, 1]. For this shape, restore to earlier tiled_load_t. Besides, add a reshape for attn mask that with only 2 ranks and expand to 4 ranks by adding 1.
clee30
force-pushed
the
sdpa_micro_attn_mask
branch
from
e269209 to
3a8cb3d
Compare
|
It resolved (at least some) functional issue. Could you rebase your working branch? |
sshlyapn
approved these changes
Jul 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier 3b84486 commit has caused kernel compilation error for shape of [batch, num_heads, 1, 1]. For this shape, restore to earlier tiled_load_t. The failure only happen if running in static shape.
CVS-170417, CVS-170820