[ONNX] Investigate the impact of removing legacy ops domain fixup #31970
+2
−45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…i.onnx domain in some legacy models was done just to investigate the effect
|
build_jenkins |
|
@RajeevSekar Do we have a ticket for this work? What models will we lose if we drop these operations? |
|
@mvafin There is a ticket for this (CVS-170160). The models affected in the unit tests are only 2 (which I have marked as skipped). I was working with Georgy on this, it was suggested by him to remove this transformation because all the models which have wrongly registered these operators are very old (from opset 1). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.