-
Couldn't load subscription status.
- Fork 2.8k
Add enable_weightless property #32345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add enable_weightless property #32345
Conversation
17a0875 to
f87c97d
Compare
f87c97d to
d28c01a
Compare
- update plugins - add tests for ENABLE_WEIGHTLESS in CPU plugin Signed-off-by: Pawel Raasz <[email protected]>
Signed-off-by: Pawel Raasz <[email protected]>
Signed-off-by: Pawel Raasz <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from GPU perspective.
I suggest also adding the property to the Python API (src/bindings/python/src/pyopenvino/core/properties/properties.cpp, src/bindings/python/src/openvino/_pyopenvino/properties/__init__.py).
| * @param config Input configuration to examine. | ||
| * @return std::nullopt If input configuration doesn't define to enable/disable weightless blob. | ||
| * @return true If ENABLE_WEIGHTLESS:true | ||
| * @return true If no ENABLE_WEIGHTLESS and CACHE_MODE:OPTIMIZE_SIZE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is not it quite complicated for users? In particular, in the CPU plugin these options do the same things. Can we remove the CACHE_MODE at least?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not doing the same. by default cache mode enable/disable WL blob
but is not possible to make WL blob for mode is speed or disable when cache mode is size
Signed-off-by: Pawel Raasz <[email protected]>
Signed-off-by: Pawel Raasz <[email protected]>
Signed-off-by: Pawel Raasz <[email protected]>
Signed-off-by: Pawel Raasz <[email protected]>
5a87a6d
Details:
ENABLE_WEIGHTLESSpropert.Related PRs:
Tickets: