-
Notifications
You must be signed in to change notification settings - Fork 2.8k
[CPU] Introduce GatherMatmul operation to optimize MoE pattern #32450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
maxnick
wants to merge
42
commits into
openvinotoolkit:master
Choose a base branch
from
maxnick:cpu_moe_op_support
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,942
−185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2. initMoE2GeMMSubgraph builder is moved to a separate file 3. initMoE3GeMMSubgraph
7d01283 to
a6d5711
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
category: Core
OpenVINO Core (aka ngraph)
category: CPP API
OpenVINO CPP API bindings
category: CPU
OpenVINO CPU plugin
category: IE Tests
OpenVINO Test: plugins and common
category: transformations
OpenVINO Runtime library - Transformations
Code Freeze
do_not_merge
do_not_review
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
In this PR we introduce yet another operation "GatherMatmu", which essentially does gemv operations over the current tokens and the active experts.
As the first step, we perform gemv operation using the dnnl::inner_product. But obviously this solution is suboptimal, as it doesn't give a fine grain control over parallelization, and in the case of many tokens being processed by a specific expert (prefill), having gemm operation may be more optimal as the tokens may be batched and we can do SIMD level parallelization by tokens as well.
Also this PR contains all the essential transformations that allow to enable a few common MoE patterns.
MoE pattern matcher is based on #32183
Related oneDNN fork PR: openvinotoolkit/oneDNN#292
Tickets: