Skip to content

feat: Add support for SHA-512 into the existing SHA-256 VM chip #1369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 27 commits into from
Closed

feat: Add support for SHA-512 into the existing SHA-256 VM chip #1369

wants to merge 27 commits into from

Conversation

Avaneesh-axiom
Copy link
Contributor

@Avaneesh-axiom Avaneesh-axiom commented Feb 14, 2025 •
edited
Loading

WIP

Note: need to update openvm commit in examples/sha2/Cargo.toml to develop after PR is merged.

Closes INT-3213

@Avaneesh-axiom Avaneesh-axiom marked this pull request as draft February 14, 2025 17:47
@Avaneesh-axiom Avaneesh-axiom changed the title [feat] Add support for SHA-512 into the existing SHA-256 air [feat] Add support for SHA-512 into the existing SHA-256 VM chip Feb 14, 2025
@Avaneesh-axiom Avaneesh-axiom changed the base branch from develop to main March 28, 2025 16:58
@Avaneesh-axiom Avaneesh-axiom mentioned this pull request Mar 28, 2025
Closed
@Avaneesh-axiom Avaneesh-axiom force-pushed the feat/sha-512-vm-chip branch 2 times, most recently from 55d1046 to 3f2d13b Compare April 4, 2025 18:03
@Avaneesh-axiom Avaneesh-axiom changed the base branch from main to develop April 4, 2025 20:00
@jonathanpwang jonathanpwang changed the title [feat] Add support for SHA-512 into the existing SHA-256 VM chip feat: Add support for SHA-512 into the existing SHA-256 VM chip Apr 4, 2025
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 7, 2025

group app.proof_time_ms app.cycles app.cells_used leaf.proof_time_ms leaf.cycles leaf.cells_used
verify_fibair (+7 [+0.5%]) 1,282 334,023 17,675,870 - - -
fibonacci_program (-8 [-0.3%]) 2,689 1,500,277 50,589,503 - - -
regex_program (+36 [+0.4%]) 8,091 4,165,226 166,511,152 - - -
ecrecover_program (-34 [-2.3%]) 1,420 289,447 14,470,186 - - -
pairing (-197 [-4.0%]) 4,735 1,820,436 95,832,407 - - -

Commit: 2df8c2a

Benchmark Workflow

@Avaneesh-axiom
Copy link
Contributor Author

Replaced by new PR #1561 which has better organized commits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathanpwang jonathanpwang Awaiting requested review from jonathanpwang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Avaneesh-axiom