Skip to content

Conversation

jonathanpwang
Copy link
Contributor

The merge queue is unstable and blocking PR merges due to not all jobs completing from workflow API flakiness or runner flakiness.

We will go back to merging to main and running workflows on push to main for now.

Additionally, I consolidated the primitives, vm, recursion CUDA tests to one runner to save some runners (and possibly compile time).

@Copilot Copilot AI review requested due to automatic review settings August 27, 2025 00:02
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the unstable merge queue functionality and consolidates CUDA test workflows to optimize CI resource usage. The merge queue was causing PR merge blockages due to API and runner flakiness, so the project is reverting to direct merges to main with workflows running on push.

  • Disabled merge queue by commenting out triggers and adding workflow_dispatch only
  • Added push triggers on main branch to all workflow files to run tests after merges
  • Consolidated separate CUDA tests from primitives, vm, and recursion workflows into a single base-tests.cuda.yml workflow

Reviewed Changes

Copilot reviewed 18 out of 18 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
.github/workflows/merge-queue-controller.yml Disabled merge queue by commenting out triggers and adding explanatory note
.github/workflows/base-tests.cuda.yml New consolidated workflow combining CUDA tests from multiple components
.github/workflows/recursion.yml Removed separate CUDA test job that's now handled in base-tests.cuda.yml
.github/workflows/vm.yml Removed CUDA runner from matrix and added push trigger
.github/workflows/primitives.yml Removed CUDA runner from matrix and added push trigger
Multiple workflow files Added push triggers on main branch for post-merge testing

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link

group app.proof_time_ms app.cycles app.cells_used leaf.proof_time_ms leaf.cycles leaf.cells_used
verify_fibair (+10 [+3.7%]) 277 322,610 2,058,654 - - -
fibonacci (-10 [-1.0%]) 1,010 1,500,210 1,060,232 - - -
regex (+35 [+1.2%]) 2,937 4,108,483 13,403,604 - - -
ecrecover (+2 [+0.2%]) 1,148 140,497 2,275,056 - - -
pairing (+19 [+1.2%]) 1,610 1,882,939 23,722,622 - - -

Commit: ce0f8aa

Benchmark Workflow

@jonathanpwang jonathanpwang merged commit f7236ea into main Aug 27, 2025
44 of 50 checks passed
@jonathanpwang jonathanpwang deleted the ci/remove-mq branch August 27, 2025 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant