Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds patterns to the generated sprite.
Unfortunately the style spec does not have any mechanism for controlling the spacing of patterns (mapbox/mapbox-gl-js#4250). So the only solution right now is to pre-render the patterns with the desired spacing.
For linear patterns, this should only require expanding the SVG viewbox to add the spacing before rendering the sprite. For staggered patterns, this will require duplicating the symbol in the SVG with the stagger offset.
Many patterns also have min/max spacing. Using zoom expressions, it should be possible to use different images from the sprite at different zoom levels. For linear patterns, it should be possible to only include the symbol in the sprite once with the maximum spacing, and then add multiple entries in the sprite JSON with different spacing for each zoom. For staggered patterns, the SVG will need to be drawn at each zoom level, and the symbol will be duplicated in the sprite.
cc #12