Get rid of ENV hacking and fix the baseURL setting. #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `getAssetURL` as a helper in the `RenderApp::Plugin::Assets` plugin module. This method should be used for any javascript or css files to ensure that the baseURL setting is correctly utilized. The language used for determining if a right-to-left css file is needed is an optional last argument. When rendering the `language` form parameter can set this, and in all cases the fall back is the `language` set in the app configuration. The only environment variables that are set are those that are needed for rendering. The renderer code itself should generally pass the controller object in where needed and configuration values should be extracted from there instead of setting environment variables corresponding to each configuration value. Also move the public/js/apps directories directly in public/js. This was done for webwork2 and PG a while ago, and should be done here as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
getAssetURLas a helper in theRenderApp::Plugin::Assetsplugin module. This method should be used for any javascript or css files to ensure that the baseURL setting is correctly utilized.The only environment variables that are set are those that are needed for rendering. The renderer code itself should generally pass the controller object in where needed and configuration values should be extracted from there instead of setting environment variables corresponding to each configuration value.
Also move the public/js/apps directories directly in public/js. This was done for webwork2 and PG a while ago, and should be done here as well.