Update third party npm dependencies. #2788
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following dependencies are updated: * @fortawesome/fontawesome-free: 6.52 -> 7.0.0 * bootstrap: 5.3.3 -> 5.3.7 * iframe-resizer: 4.3.11 -> 4.4.2 * jquery-ui-dist: 1.13.2 -> 1.13.3 * luxon: 3.4.4 -> 3.7.1 * sortablejs: 1.15.2 -> 1.15.6 * autoprefixer: 10.4.19 -> 10.4.21 * chokidar: 3.6.0 -> 4.0.3 * cssnano: 6.1.2 -> 7.1.0 * postcss: 8.4.38 -> 8.5.6 * prettier: 3.2.5 -> 3.6.2 * rtlcss: 4.1.1 -> 4.3.0 * sass: 1.75.0 -> 1.90.0 * terser: 5.30.4 -> 5.43.1 * yargs: 17.7.2 -> 18.0.0 All libraries except for `iframe-resizer` are at their latest versions. The `iframe-resizer` library has changed considerably and upgrading to the latest version requires quite a few changes. Furthermore, they now have a commercial license version (which requires purchase) and an open source license version. We can use the open source version, but there are some annoying things that they do with that (like console logs that you can't prevent). I have chosen the last version available before things went haywire and `iframe-resizer` started doing stupid things. Note that the there are two changes to the the generate-assets.js script that were needed. There is a change in how yargs is used, and an option needed to be added to the `sass.compile` call to disable warnings about deprecated sass usage in Bootstrap's scss.
The `iframe-resizer` has been replaced with the `@iframe-resizer/parent` and `@iframe-resizer/child` packages. The latest version is 5.5.2 which this upgrades to. There are several changes needed for this. The `data-iframe-height` and `data-iframe-width` options are deprecated and now there is only the `data-iframe-size` option. This requires a small change to PG as well. Also, the `iFrameResize` method is deprecated and replaced with the `iframeResize` method (annoying change here). The `iFrameResizer` property set on the iframe still exists but is not documented. The `iframeResizer` property replaces it. I assume the `iFrameResizer` is also deprecated, so that switch was made.
drgrice1
force-pushed
the
update-npm-dependencies
branch
from
d026936 to
26d8555
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following dependencies are updated:
All libraries are now at their latest versions.
Note that the there are two changes to the the generate-assets.js script that were needed. There is a change in how yargs is used, and an option needed to be added to the
sass.compilecall to disable warnings about deprecated sass usage in Bootstrap's scss.The
iframe-resizerlibrary has changed considerably and upgrading to the latest version requires quite a few changes.First, the
iframe-resizerpackage has been replaced with the@iframe-resizer/parentand@iframe-resizer/childpackages. The latest version is 5.5.2 which this upgrades to.Second, the
data-iframe-heightanddata-iframe-widthoptions are deprecated (and in fact don't work) and now there is only thedata-iframe-sizeoption. This requires a small change to PG as well (done in the last commit of openwebwork/pg#1306). Also, theiFrameResizemethod is deprecated and replaced with theiframeResizemethod (annoying change here, did you really need to change the case of one letter). TheiFrameResizerproperty set on the iframe still exists but is not documented. TheiframeResizerproperty replaces it. I assume theiFrameResizeris also deprecated (although this is not documented), so that switch was made.Furthermore, they now have a commercial license version (which requires purchase) and an open source license version. We can use the open source version, but there are some annoying things that they do with that (like console logs that you can't prevent).
The first commit in this pull request upgrades iframe-resizer to version 4.4.2 which is the last version before things went haywire ans started doing stupid things. The last commit in this pull request further upgrades to 5.5.2 and the new packages. We can revert the last commit if we decide we can't tolerate these changes.