Open
Conversation
Replace supervisorctl reload with a targeted restart of
openwisp-flask-vpn-updater-{{ openwisp2_wireguard_vpn_uuid }} and add safe
register/failed_when/changed_when logic to avoid failing when the process
is absent. Update task notifications accordingly.
Fixes : openwisp#47
nemesifier
reviewed
Dec 20, 2025
Member
nemesifier
left a comment
nemesifier
left a comment
There was a problem hiding this comment.
The CI build is failing due to QA checks and I can't see whether the rest of the implementation works.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for RHEL 7 and 8 to the CI build matrix.
Since standard RHEL images require a subscription, this implementation uses the community equivalents:
This ensures that the role is automatically tested against these platforms in the CI pipeline using the existing Molecule configuration.
Related Issue
Closes #3
Type of Change
Verification
distro: centos7anddistro: rockylinux8to the .github/workflows/ci.yml matrix.