Draft: [notifications] Respect Django permissions for notification preferences

[panagiotisevaggelou]

This pull request adds permission checks for viewing and editing notification preferences, both in the API and in the admin interface.

Checklist

• I have read the OpenWISP Contributing Guidelines.
• I have manually tested the changes proposed in this pull request.
• I have written new test cases for new code and/or updated existing tests for changes to existing code.
• I have updated the documentation.

Reference to Existing Issue

Closes #312

Description of Changes

• Updated PreferencesPermission in api/permissions.py and test_func in views.py to apply proper access rules.
• Added a new template tag can_change_notifications to control when the “Notification Preferences” button is shown.
• Added tests for all cases (superuser, regular user, staff with/without permission, and organization management).
• Added extra comments in the code to make the logic easier to understand.

Notes

See my comment on the issue for more details.
This is a Draft PR and I would like some feedback, so I know I am on the right path.

Screenshot

[nemesifier]

@coderabbitai review

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[coderabbitai]

Warning

Rate limit exceeded

@nemesifier has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 24 minutes and 41 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between dc78de5 and 5b31ec4.

📒 Files selected for processing (5)

• openwisp_notifications/api/permissions.py
• openwisp_notifications/templates/admin/base_site.html
• openwisp_notifications/templatetags/notification_tags.py
• openwisp_notifications/tests/test_api.py
• openwisp_notifications/views.py

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[nemesifier]

@panagiotisevaggelou thanks for contributing! The CI build is failing, please follow up with the reviews from coderabbit.

Sorry for my late repsonse, we've been avalanched with pull requests.