docs: clarify sharenfs documentation and add examples #17914
+35
−62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed mandoc warnings and improved formatting in the sharenfs property documentation for better readability. Signed-off-by: Kotini Jeshwanth <[email protected]>
2400032703kotinijeswanth
force-pushed
the
docs/sharenfs-update
branch
from
56adc95 to
0bd6122
Compare
Contributor
|
Cc @gmelikov |
gmelikov
suggested changes
Nov 11, 2025
Member
There was a problem hiding this comment.
- Why is
docs/Recovering-Pool-Import-Issue.mdhere? - Why did you remove majority of old description?
In PR you said
Explaining on/off/options behavior
Describing host-specific and global options
Adding examples and limitations (e.g., pnfs, security_label unsupported)
Where are all these changes? I don't see any limitations info, for ex. about pnfs. All I see is rephrase and removal of old texts with some old knowledge missing.
Sorry, but I don't see any improvement now. I want to be explicit and ask - did you create these changes by yourself? It looks like LLM without any good after thought.
Did you use ZFS with this option?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the sharenfs property documentation by:
Fixes sharenfs documentation #11159