Skip to content

Got rid of LIBZIM_WITH_XAPIAN in a public header file

5d00100
Select commit
Loading
Failed to load commit list.
Merged

Cleanup of suggestions code #1006

Got rid of LIBZIM_WITH_XAPIAN in a public header file
5d00100
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 26, 2025 in 1s

58.13% (+0.17%) compared to 0db0295

View this Pull Request on Codecov

58.13% (+0.17%) compared to 0db0295

Details

Codecov Report

❌ Patch coverage is 60.36036% with 44 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.13%. Comparing base (0db0295) to head (5d00100).

Files with missing lines Patch % Lines
src/suggestion_iterator.cpp 61.38% 8 Missing and 31 partials ⚠️
src/suggestion.cpp 16.66% 0 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1006      +/-   ##
==========================================
+ Coverage   57.96%   58.13%   +0.17%     
==========================================
  Files         101      101              
  Lines        5407     5384      -23     
  Branches     2219     2197      -22     
==========================================
- Hits         3134     3130       -4     
+ Misses        800      795       -5     
+ Partials     1473     1459      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.