Draft
Conversation
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #1043 +/- ##
=======================================
Coverage 56.25% 56.25%
=======================================
Files 101 101
Lines 5016 5016
Branches 2185 2185
=======================================
Hits 2822 2822
Misses 738 738
Partials 1456 1456 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
veloman-yunkan
left a comment
veloman-yunkan
left a comment
There was a problem hiding this comment.
Line 176 in src/writer/cluster.cpp will lead to a similar compilation error when using C++23.
| auto cluster_index_type = idx.v; | ||
| auto key = std::make_tuple(this, cluster_index_type); | ||
| auto cluster = getClusterCache().getOrPut(key, [=](){ return readCluster(idx); }); | ||
| auto cluster = getClusterCache().getOrPut(key, [=, this](){ return readCluster(idx); }); |
Collaborator
There was a problem hiding this comment.
Some compilers don't like this (pun intended). Try [this, idx]() ... instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small syntax improvement, to prepare the future