-
-
Notifications
You must be signed in to change notification settings - Fork 29
Move to libzim 9.4.0 #234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Move to libzim 9.4.0 #234
Conversation
6903eb3 to
9abd25c
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #234 +/- ##
==========================================
+ Coverage 93.69% 93.77% +0.08%
==========================================
Files 1 1
Lines 539 546 +7
==========================================
+ Hits 505 512 +7
Misses 34 34 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
257b200 to
dd66c0e
Compare
|
@rgaudin do you have any idea about how to fix the wheel build error on Ubuntu cp39 aarch64? Is this something which is induced by libzim 9.4.0 or did I broke something? I tried update CI actions (kinda desperate move tbh) but it did not helped except having much nicer logs for the wheel building action. |
538514d to
c1f4dc1
Compare
|
I use this link and this one to check which distro version has which glibc version easily. It's not up to date unfortunately but Ubuntu jammy 22.04 has glibc 2.35. Regular libizim is now built on jammy so if we were to use it, we could only link on images that supports 2.35+. We would thus need to update our
That's why we don't use regular libzim in pylibzim but a special build named manylinux. It's built on I see here though that this is an x86_64 image so obviously there will be issues on aarch64. You can open a ticket in kiwix-build because this is a problem |
|
Thank you! In addition,
|
d793efa to
11916b4
Compare
|
Blocked by kiwix/kiwix-build#881 for the time being |
11916b4 to
75c4e87
Compare
75c4e87 to
0f0820a
Compare
|
This is now ready for review, only waiting for kiwix/kiwix-build#884 to be merged and released |
|
It's available and should be working |
|
@rgaudin can you please review this PR? |

This is a minimal PR to move to libzim 9.4.0
It does not add new stuff like the new illustrations API (I propose to do this in a distinct PR #233)
It adapts to libzim changes:
Archive.dirent_lookup_cache_max_size, does not exists anymore in libzimArchive.cluster_cache_max_sizeandArchive.cluster_cache_current_sizeto methods outside ofArchiveobject:get_cluster_cache_max_size,set_cluster_cache_max_size,get_cluster_cache_current_size(size is now in bytes)get_illustration_sizes()