Skip to content

feat: complete dev work — bug fixes, API v1, webhooks, templates, countersign & FE sync#26

Merged
paresh011 merged 0 commit intomainfrom
sync-design
Mar 24, 2026
Merged

feat: complete dev work — bug fixes, API v1, webhooks, templates, countersign & FE sync#26
paresh011 merged 0 commit intomainfrom
sync-design

Conversation

@darshgupta-wisdm
Copy link
Copy Markdown
Collaborator

@darshgupta-wisdm darshgupta-wisdm commented Mar 17, 2026

Summary

  • 85+ bugs fixed from 512-item bug report (security, type safety, React, schema validation)
  • REST API v1 — API key auth system + 15 P0 endpoints (Quotes, Invoices, Clients) with rate limiting
  • Webhook system — 12 event types with delivery logs and retry
  • Invoice templates — full CRUD with DB persistence
  • Countersign flow — dual signatures (type/draw), auto-countersign toggle in settings
  • Email settings — configurable email templates and SMTP
  • Integrations cleanup — Stripe/OAuth placeholders, webhook management UI
  • FE→ALL design sync (round 2) — analytics simplified, help page redesigned, page cleanups
  • Build fix — replaced Prisma Decimal import with duck-typed interface
  • Build passes — all 77 pages, zero errors

Test plan

  • pnpm build passes with zero errors
  • Verify dashboard, quotes, invoices, clients, projects, contracts pages load
  • Test API v1 endpoints with API key auth
  • Test webhook delivery and logs
  • Test invoice template CRUD
  • Test countersign flow on contracts
  • Verify email settings save correctly

🤖 Generated with Claude Code

@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 17, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
quote-software Ready Ready Preview, Comment Mar 24, 2026 11:16am

Request Review

@paresh011
Copy link
Copy Markdown
Collaborator

Added PR review report below PR-Review-QuoteCraft-v2 (1).docx

Please fix them

@paresh011
Copy link
Copy Markdown
Collaborator

Check this review after recent fixes PR-Review-QuoteCraft-FINAL.docx

@darshgupta-wisdm
Copy link
Copy Markdown
Collaborator Author

Hi Paresh,

All review findings have been addressed:

  • 13 fixed from the initial review (C-1, M-1 through M-8, m-2, m-4, m-5, m-7)
  • 2 new issues found in re-review also fixed (N-1: atomic declineQuote, N-2: removed debug logs)
  • C-2 (scrollbar hiding) — this is an intentional design decision by Shubham. Confirmed with the team.

The only remaining items are non-blocking fast-follows (Zod validation on V1 routes, HSTS/CSP for Docker) and pre-GA items (PDF strategy, migration files).

CI is all green — lint, type-check, unit tests (986 passing), and build all pass. Ready to merge whenever you get a chance.

@paresh011 paresh011 merged this pull request into main Mar 24, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants