fix: PDF download crash during quote/invoice creation#62
Open
darshgupta-wisdm wants to merge 1 commit intomainfrom
Open
fix: PDF download crash during quote/invoice creation#62darshgupta-wisdm wants to merge 1 commit intomainfrom
darshgupta-wisdm wants to merge 1 commit intomainfrom
Conversation
Disable download buttons on new quote/invoice pages (not yet saved). On edit pages, use server-side PDF API instead of broken html2canvas. Remove ~500 lines of dead html2canvas code (hidden A4 render divs). Fixes #61 Port of orekoapp/oreko-pro#11. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/api/pdf/quote/{id}) instead of broken html2canvasFixes #61
Port of orekoapp/oreko-pro#11.
Files changed
apps/web/app/(dashboard)/invoices/new/new-invoice-form.tsxapps/web/app/(dashboard)/quotes/[id]/edit/edit-quote-form.tsxapps/web/app/(dashboard)/quotes/new/new-quote-form.tsxTest plan
🤖 Generated with Claude Code