-
-
Notifications
You must be signed in to change notification settings - Fork 480
updated project dependencies and move everything to yarn workspace #2303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It finally passes! There's a lot going on here. But besides node 20+ being required this shouldn't break anything in the packages. |
@anymaniax thoughts? I feel like this is a good improvement |
@soartec-lab @AllieJonsson anyone else any thoughts? |
Ill have a try tomorrow, but it seems fine by me |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @snebjorn Thank you for this great improvement. I would like to incorporate these improvements and would like to request them.
This PR contains several different changes and is getting quite large. Would it be possible to split them up and rebuild them as separate PRs? At the very least, the package upgrades, the yarn workspace
enhancements, the typing changes, etc. should be separable.
I can try. But moving to yarn workspaces was what made it all break. |
@snebjorn |
@soartec-lab I'm not close to done :) But Last Epoch and Path of Exile 2 seasons are starting now. So expect a drastic drop off in productivity 😄 |
@snebjorn No problem. Is it a game? That's a great hobby! |
Ok merge conflicts |
@melloware as per #2303 (review) the plan with this one is to break it up into many smaller PRs. |
Understood |
I believe everything have been merged now 🎉 - closing |
Status
READY
Description
First of... I'm sorry, this got a bit out of hand. What happened was
https://youtu.be/5W4NFcamRhM?si=ZcqkBgbp1FGEylKK
I wanted to update yarn, turbo and tsup.
Then I want to utilize yarn workspace better so we easily could go to the orval source from the samples.
But once I did that A LOT of stuff broke! I have no idea why 😢
I had to update the minimum node version to 20. Not sure what it was before, 12? 18?
Anyway