Skip to content

Conversation

snebjorn
Copy link
Contributor

@snebjorn snebjorn commented Aug 9, 2025

Status

READY

Description

First of... I'm sorry, this got a bit out of hand. What happened was
https://youtu.be/5W4NFcamRhM?si=ZcqkBgbp1FGEylKK

I wanted to update yarn, turbo and tsup.
Then I want to utilize yarn workspace better so we easily could go to the orval source from the samples.
But once I did that A LOT of stuff broke! I have no idea why 😢
I had to update the minimum node version to 20. Not sure what it was before, 12? 18?

Anyway

  • all samples work and generate the exact same as before
  • all sample tests work
  • all tests work
  • docs work

@snebjorn
Copy link
Contributor Author

It finally passes!
Oh man this have been a roller coaster of fix 1 thing, break 2 seemingly unrelated things.

There's a lot going on here. But besides node 20+ being required this shouldn't break anything in the packages.
Let me know what you think.

@melloware
Copy link
Collaborator

@anymaniax thoughts? I feel like this is a good improvement

@melloware melloware added the enhancement New feature or request label Aug 10, 2025
@melloware melloware requested a review from anymaniax August 10, 2025 13:31
@melloware
Copy link
Collaborator

@soartec-lab @AllieJonsson anyone else any thoughts?

@AllieJonsson
Copy link
Contributor

Ill have a try tomorrow, but it seems fine by me

Copy link
Member

@soartec-lab soartec-lab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @snebjorn Thank you for this great improvement. I would like to incorporate these improvements and would like to request them.
This PR contains several different changes and is getting quite large. Would it be possible to split them up and rebuild them as separate PRs? At the very least, the package upgrades, the yarn workspace enhancements, the typing changes, etc. should be separable.

@snebjorn
Copy link
Contributor Author

I can try. But moving to yarn workspaces was what made it all break.
If I recall correctly what I did was update turbo, that sort of worked.
Then I did the yarn workspace thing and that's when everything just broke. All changes from that point forward was to get it working using yarn workspaces.

@soartec-lab
Copy link
Member

@snebjorn
Thank you. We will review each PR individually. Once we have addressed all of them, we will close this PR!

@snebjorn
Copy link
Contributor Author

@soartec-lab I'm not close to done :) But Last Epoch and Path of Exile 2 seasons are starting now. So expect a drastic drop off in productivity 😄

@soartec-lab
Copy link
Member

@snebjorn No problem. Is it a game? That's a great hobby!

@melloware
Copy link
Collaborator

Ok merge conflicts

@snebjorn
Copy link
Contributor Author

@melloware as per #2303 (review) the plan with this one is to break it up into many smaller PRs.
We're keeping this one open until everything is merged via mini PRs :)

@melloware
Copy link
Collaborator

Understood

@snebjorn
Copy link
Contributor Author

I believe everything have been merged now 🎉 - closing

@snebjorn snebjorn closed this Sep 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants