Draft
Conversation
Adds better editor support for detailing the purpose of the methods and functions in this application.
Prevents the files that were not previously committed from being committed on accident now.
This is a solid start that allows the user to configure the font, size, and style, but it still lacks a way to get text from the user and add it to the canvas.
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the start of an implementation of the text editing feature requested in os-js/osjs-draw-application#13 on the main OS.js repository.
The PR is not ready yet, but I wanted to go ahead and open this in case I don't have the time to finish it if somebody else would like to continue where I left off. The user can currently configure the font options for the text to add, but the user cannot yet enter text or add it to the canvas.