DOM changes for more consistent positioning of menu.

[corwin-of-amber]

This is related to #26, I will rebase it after this one is merged.

[corwin-of-amber]

Ok seems that I am going to rebase this one on top of #26 instead of vice versa.

[corwin-of-amber]

🍴

[andersevenrud]

I think I might have to find an alternative to Codacy. It gets drunk way to often and produce some weird errors/warnings :P

[corwin-of-amber]

I wonder if that have anything to do with my force-pushing all the time.

[andersevenrud]

The weird thing is that it only triggers errors on the lines you've changed 😂

[corwin-of-amber]

I think that is by design, it only checks the specific commit.
But definitely some other commits had single quotes in them and those were found ok...

[andersevenrud]

I think I figured it out. Seems like Codacy does not read linter configurations from package.json 🤦‍♂️ I moved all the dotfile configuration there in pretty much all base libraries this week.

So I've disabled Codacy pull request checks, and instead moved over to CodeClimate which I use on some other stuff -- and I'll try to move everything there.

I'll see if closing and re-opening this triggers the correct integrations 🤔

[andersevenrud]

Sorry if this is spamming you. Seems like the previous Codacy check won't go away 😂

[corwin-of-amber]

Want me to make a fresh PR?

[corwin-of-amber]

Hi, I rebased this fix so that it runs on Code Climate but now the config is borked...

[andersevenrud]

I've seen this in some other repos as well. Not quite sure why it happens as Codeclimate just uses the stylelint engine 🤔 But clearly it has something to do with dependencies for stylelint in particular, because eslint does not behave like this.

I'll try to contact support.

Edit Support link: gilbarbara/codeclimate-stylelint#38

[corwin-of-amber]

I forgot about this little PR, I have rebased it now and the CI seems to work!

[andersevenrud]

I totally forgot as well! I'll have to review this and get back to you 😊