build(deps): Bump github.com/lib/pq from 1.10.6 to 1.12.3#877
build(deps): Bump github.com/lib/pq from 1.10.6 to 1.12.3#877dependabot[bot] wants to merge 1 commit intov0.34.xfrom
Conversation
Bumps [github.com/lib/pq](https://github.com/lib/pq) from 1.10.6 to 1.12.3. - [Release notes](https://github.com/lib/pq/releases) - [Changelog](https://github.com/lib/pq/blob/master/CHANGELOG.md) - [Commits](lib/pq@v1.10.6...v1.12.3) --- updated-dependencies: - dependency-name: github.com/lib/pq dependency-version: 1.12.3 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
LabelsThe following labels could not be found: Please fix the above issues or remove invalid values from |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 770595d. Configure here.
| module github.com/tendermint/tendermint | ||
|
|
||
| go 1.18 | ||
| go 1.21 |
There was a problem hiding this comment.
Go version bump breaks all CI and Docker builds
High Severity
The go directive was silently bumped from 1.18 to 1.21 as a side effect of upgrading lib/pq to v1.12.3. However, all existing build infrastructure still references Go 1.18: CI workflows (.github/workflows/coverage.yml, .github/workflows/check-generated.yml, .github/workflows/e2e-manual.yml), Dockerfiles (DOCKER/Dockerfile, test/docker/Dockerfile, test/e2e/docker/Dockerfile), and scripts/proto-gen.sh. Building Go 1.21-required code with a Go 1.18 toolchain will fail, breaking CI, Docker builds, and the documented Go version badge in README.md.
Reviewed by Cursor Bugbot for commit 770595d. Configure here.


Bumps github.com/lib/pq from 1.10.6 to 1.12.3.
Release notes
Sourced from github.com/lib/pq's releases.
... (truncated)
Changelog
Sourced from github.com/lib/pq's changelog.
... (truncated)
Commits
1f3e3d9Send datestyle as a startup parameter (#1312)32ba56bExpand tests for multiple result setsc2cfac1Release v1.12.2859f104Test CockroachDB12e464cAllow multiple matches and regexps in pqtest.ErrorContains()6d77cedTreat io.ErrUnexpectedEOF as driver.ErrBadConn in handleError71daecbEnsure transactions are closed in pqtest8f44823Set PGAPPNAME for tests4af2196Fix healthcheck38a54e4Split out testdata/init a bitDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)Note
Medium Risk
Dependency-only change, but raising the module
goversion from 1.18 to 1.21 can affect build/test behavior and CI/toolchain compatibility.Overview
Updates the module
goversion from 1.18 to 1.21.Bumps the PostgreSQL driver dependency
github.com/lib/pqfromv1.10.6tov1.12.3and refreshesgo.sumentries accordingly.Reviewed by Cursor Bugbot for commit 770595d. Bugbot is set up for automated code reviews on this repo. Configure here.