fix: Preserve original license operator when applying license mappings#10995
Draft
daniel-kr wants to merge 1 commit intooss-review-toolkit:mainfrom
Draft
Conversation
Signed-off-by: Daniel Kreck <daniel.kreck@cplace.com>
daniel-kr
force-pushed
the
preserve-original-license-operator-upon-license-mapping
branch
from
e34ea7f to
14170c4
Compare
sschuberth
reviewed
Oct 20, 2025
| } | ||
| } | ||
|
|
||
| "preserve OR operator when mapping makes previously invalid licenses valid" { |
Member
There was a problem hiding this comment.
Just as a remark to begin with / as a note to myself: We cannot generally assume that OR needs to be preserved in this test, as the operator is package-type-specific.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up fix of #10961.
There is an edge case where the original fix doesn't work: In case of two declared licenses of which one is no proper SPDX license expression. If a declared license mapping is applied via package curation the default operator
ANDinstead ofORis used for combining the two declared licenses.Fixes #10721.