update: added confirmation when a salary les than 10000 is entered - #344
update: added confirmation when a salary les than 10000 is entered#344LL-Etiane wants to merge 1 commit into
Conversation
| this.$store.dispatch('postRating', this.newRating) | ||
| this.$router.push('/') | ||
| } | ||
| } else { |
There was a problem hiding this comment.
LGTM, but make sure to have a confirmation from a frontend here like @Asam237 !
Also, it could be great to have those lines formatted maybe 🤔 ?
There was a problem hiding this comment.
Thanks. I will contact @Asam237 for confirmation.
For the code formatting will format it.
|
@Asam237 review from a frontend dev needed |
|
It adds three 0. simplescreenrecorder-2022-10-27_22.20.17.mp4 |
|
Hey! @LL-Etiane thanks for helping on this issue. I love the warning added when the user enters a funny amount We can use a prompt message to ask the user to verify his input but we cannot force the user to enter a different input. |
|
Any update here? |
6 participants
This pull request ask for users confirmation when a salary amount less than 10000 is entered
Why ?
This is to prevent mistake inputs by users when they sometimes input amounts such as 250 or 1. This is to solve #343
How ?
Let us know how it does what it does