chore: integrate against new version of si-tooling#83
Draft
chore: integrate against new version of si-tooling#83
Conversation
Contributor
Author
|
I believe that this ossf/security-insights#134 is the way to unlock further success here |
trumant
force-pushed
the
integrate-against-si-cue
branch
from
f506877 to
fbfbd09
Compare
trumant
commented
May 8, 2025
go.mod
Outdated
|
|
||
| // replace github.com/revanite-io/sci => ../sci | ||
|
|
||
| replace github.com/ossf/si-tooling/v2 => github.com/trumant/si-tooling/v2 v2.0.0-20250508125303-b3bcfe09fe10 |
Contributor
Author
There was a problem hiding this comment.
This is pointing to my branch ossf/si-tooling#26
trumant
force-pushed
the
integrate-against-si-cue
branch
2 times, most recently
from
e9b025d to
0bcdc5a
Compare
Signed-off-by: Travis Truman <trumant@gmail.com>
trumant
force-pushed
the
integrate-against-si-cue
branch
from
0bcdc5a to
6c7247b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Obviously leaving in the
replace...ingo.modis going to make the checks fail on this PR, but its mainly to discuss what we want to do about the struct embedding mess seen in:-
evaluation_plans/reusable_steps/evaluations_test.go:30:23-
evaluation_plans/osps/vuln_management/steps_test.go:30:21