Merged
Conversation
Signed-off-by: Travis Truman <trumant@gmail.com>
Member
Member
|
@trumant to be clear, you are correct, it is a list but if we're just applying one label I think a string will work. Having labels as a list, allows for future ones. Do we think it's best to use a list for that future possibility? 🤔 |
Contributor
Author
|
I think it's best to specify a YAML list with a single list item, because the schema declares the field to be of type list. The comma-delimited string is a holdover from the Markdown with YAML front matter days I believe. VS Code YAML validation was nagging about it because it somehow found the underlying schema. |
jmeridth
approved these changes
Mar 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.