-
Notifications
You must be signed in to change notification settings - Fork 16
docs: add adoption guidance docs and example files #130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| # Repository template for a multi-repository project | ||
| # This file would be stored in the https://vcs.example.com/foobar/bar repository | ||
| header: | ||
| schema-version: 2.0.0 | ||
| last-updated: '2025-03-01' | ||
| last-reviewed: '2025-04-01' | ||
| url: https://example.com/kubernetes/kubernetes | ||
| project-si-source: https://vcs.example.com/foobar/foo/security-insights.yml | ||
|
|
||
| repository: | ||
| url: https://vcs.example.com/foobar/bar | ||
| status: active | ||
| accepts-change-request: true | ||
| accepts-automated-change-request: true | ||
| core-team: | ||
| - name: Alice White | ||
| affiliation: Foo Bar | ||
| email: alicewhite@email.com | ||
| social: https://social.example.com/alicewhite | ||
| primary: true | ||
| license: | ||
| url: https://example.com/LICENSE | ||
| expression: MIT | ||
| security: | ||
| assessments: | ||
| self: | ||
| comment: | | ||
| Self assessment has not yet been completed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| # Project and repository template for a multi-repository project | ||
| # This file would be stored in the https://vcs.example.com/foobar/foo repository | ||
| # and addressable via https://vcs.example.com/foobar/foo/security-insights.yml | ||
| header: | ||
| schema-version: 2.0.0 | ||
| last-updated: '2025-03-01' | ||
| last-reviewed: '2025-04-01' | ||
| url: https://example.com/kubernetes/kubernetes | ||
| comment: | | ||
| This file contains the minimum information for both project and repository. | ||
| It not required to include both a project and repository section if the project | ||
| section is intended to be inherited by repositories via header.project-si-source | ||
|
|
||
| project: | ||
| name: FooBar | ||
| administrators: | ||
| - name: Joe Dohn | ||
| affiliation: Foo | ||
| email: joe.bob@example.com | ||
| social: https://social.example.com/joebob | ||
| primary: true | ||
| repositories: | ||
| - name: Foo | ||
| url: https://vcs.example.com/foobar/foo | ||
| comment: | | ||
| Foo is the core repo for FooBar. | ||
| - name: Bar | ||
| url: https://vcs.example.com/foobar/bar | ||
| comment: | | ||
| Bar is also part of the FooBar project. | ||
| vulnerability-reporting: | ||
| reports-accepted: true | ||
| bug-bounty-available: true | ||
|
|
||
| repository: | ||
| url: https://vcs.example.com/foobar/foo | ||
| status: active | ||
| accepts-change-request: true | ||
| accepts-automated-change-request: true | ||
| core-team: | ||
| - name: Alice White | ||
| affiliation: Foo Bar | ||
| email: alicewhite@email.com | ||
| social: https://social.example.com/alicewhite | ||
| primary: true | ||
| license: | ||
| url: https://example.com/LICENSE | ||
| expression: MIT | ||
| security: | ||
| assessments: | ||
| self: | ||
| comment: | | ||
| Self assessment has not yet been completed. |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jranson as a recent adopter in the Trickster project, your view on this particular documentation would be very helpful. If you can give it a review and feedback/comments - I'd appreciate you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@trumant always doing first rate work. 😍
I like the flexibility here, which is great for busy maintainers who want to be good stewards around project security without it becoming burdensome . But with that flexibility comes questions. How will a maintainer know what elements that (a: apply to their project, and b: are in the gap) warrant self-reporting and which ones do not? Is there / should there be a benchmark for adequate exhaustiveness of self-reporting, and if not, how can a naive maintainer like me know what is good enough? (not that we want to just do the bare minimum, but those of use who aren't security engineers can probably use some guidance to help get it right the first time).
I didn't see that anywhere in this PR, but maybe it's elsewhere in the project? if not, is more info on acceptable self-reporting something that can be put together in a future contribution? Linking to it from the Readme when it's ready would be 👌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really appreciate your feedback @jranson
The
template-minimum.ymlexample is meant to highlight the absolutely bare minimum, but I think the more project-specific questions a maintainer has would likely be answered by us illustrating a more clear link between https://baseline.openssf.org/versions/2025-02-25 and the usage of Insights.That is feedback we've heard from other maintainers and community members before and something we're intending to address as part of ossf/security-baseline#256