Conversation
There was a problem hiding this comment.
Need to undo this/move it to be alembic-specific; we want aiomysql at runtime
|
Diffs observed from generating the base schema (This is basically the todo list for this pr) |
170f206 to
bf91e78
Compare
There was a problem hiding this comment.
I wonder if we can set this up to just defer to logging.yaml
There was a problem hiding this comment.
I wonder if we could use pre-commit hooks here? We could probably call into quite a few of them directly if we really had to. Maybe we'll find it's not worth using this & pre-commit after the fact is ok
There was a problem hiding this comment.
TODO: this is still missing the existing seed data, as well as a couple of the tables that already exist (we should really have a 1:1 representation of the existing db in this PR, so that it gives us the ability to use alembic to remove those existing parts of the schema in future PRs -- otherwise we'll have a desync between user's db states & where alembic thinks they are).
a044f62 to
1bca9ce
Compare
|
this would be epic to get in |
|
@7mochi I think this is the main thing still remaining to align: #639 (comment) |
|
resolved the merge conflicts |
* chore: fix alembic migrations * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Describe your changes
Related Issues / Projects
Checklist