add missing return after Resp403 in password handlers#252
Merged
cmyui merged 1 commit intoosuAkatsuki:masterfrom Apr 3, 2026
Merged
add missing return after Resp403 in password handlers#252cmyui merged 1 commit intoosuAkatsuki:masterfrom
cmyui merged 1 commit intoosuAkatsuki:masterfrom
Conversation
raya-ac
requested review from
cmyui,
infernalfire72 and
lenforiee
as code owners
Member
|
i don't think it actually caused fallthorugh, it seems to either redirect or error response 
but agree with the change anyways for clarity of control flow 👍🏻 |
cmyui
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #247
Without the return, unauthenticated requests fall through the auth check and continue executing with user ID 0.