Add URL encoding for Redis credentials and safer error handling in sessions#39
Closed
Copilot wants to merge 1 commit intomodernize-rust-syntaxfrom
Closed
Add URL encoding for Redis credentials and safer error handling in sessions#39Copilot wants to merge 1 commit intomodernize-rust-syntaxfrom
Copilot wants to merge 1 commit intomodernize-rust-syntaxfrom
Conversation
Copilot
AI
changed the title
[WIP] Modernize Rust syntax patterns
Add URL encoding for Redis credentials and safer error handling in sessions
Jan 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses two robustness issues identified in code review:
1. URL-encode Redis credentials
Credentials containing URL-unsafe characters (
@,:,/,?,#) would break connection string parsing. Added percent-encoding usingpercent-encodingcrate (already in dep tree):2. Replace bare
unwrap()withexpect()in sessions.rsChanged panic-on-None to include context about the invariant:
While code flow guarantees
Some, explicit message aids debugging if logic error introduced.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.