feat: vertical tab (stack) layout#316
Open
ArijanJ wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a vertical stack layout which works like tabs, but stacks vertically instead: #235
This layout is nice to use when you're constrained horizontally, and also nice because monitors are wider than they are taller - if you only use 'focus right / focus left' (i.e., when switching to a monitor to the side), you end up going into tabs you didn't intend to. Using stacks removes that issue and makes the content of the tabs easier to check, since your eyes don't have to go searching across your screen.
One thing I'm not sure about is whether any of the dispatchers should include this (e.g.,
toggletab) - that's how I switched between tabs in sway/i3 (bindsym $mod+s layout toggle stacking tabbed), but using it on its own with changegroup/makegroup is probably good enough.Disclosure: Most of this code was written by an LLM, but I reviewed each line, tested it thoroughly, fixed a couple of regressions, etc. All the things that would work with a regular tab also work with stacked tabs.