#174: Add User Action Logging#204
Open
JamesTLopez wants to merge 20 commits into
Open
Conversation
JamesTLopez
commented
Jun 1, 2026
leoraba
reviewed
Jun 3, 2026
| router.use(json()); | ||
|
|
||
| router.use(authMiddleware(authConfig)); | ||
| router.use(actionLoggerMiddleware({ enabled: authConfig.enabled }, baseDependencies.logger)); |
Contributor
There was a problem hiding this comment.
having actionLoggerMiddleware after the authMiddleware won't be called on an unauthorized request.
Contributor
There was a problem hiding this comment.
In the case of clinical there's already an implementation of a request logger, which I think will duplicate some information..
JamesTLopez
commented
Jun 14, 2026
Comment on lines
+50
to
+58
| // Capture request context after validation (when params/body/query are populated) | ||
| // Needed for logging and for error middleware to access request context | ||
| res.locals.requestContext = { | ||
| method: req.method, | ||
| path: req.originalUrl || req.path, | ||
| params: req.params, | ||
| query: req.query, | ||
| ...(req.method !== 'GET' && req.body ? { body: req.body } : {}), | ||
| }; |
Contributor
Author
There was a problem hiding this comment.
Create a locals for requestContext in the requestValidation. This ensure that the mapped params/query/body is passed into the errorHandler middleware.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add's
actionLogger.tsmiddleware that will intercept responses from endpoints and log the result returned from lyrics business logic.Issues
Description of Changes
Package Data-Provider
Add
actionLogger.ts,actionloggerUtils.tsactionLogger contains middleware that will intercept responses from lyric and log who made the request and what the result was
actionLoggerUtils contains helper function, types, formatting functions and parsing options for the logging string
add
actionLoggerMiddlewareto all endpoints in:auditRouter.tscategoryRouter.tsdictionaryRouter.tssubmissionRouter.tssubmittedDataRouter.tsvalidationRouter.tsSpecial Instructions
Before running these changes, you will need to:
Readiness Checklist
.env.schemafile and documented in the README