Skip to content

wiki: Remove deprecated REQBODY_PROCESSOR_ERROR and REQBODY_PROCESSOR_ERROR_MSG from wiki pages #3576

Description

@hnakamur

I found that REQBODY_PROCESSOR_ERROR and REQBODY_PROCESSOR_ERROR_MSG were deprecated in this commit:
d0e2546

It appears that these variables have not been assigned any values in the v2/master branch since then.

Therefore, I think we should either remove REQBODY_PROCESSOR_ERROR and REQBODY_PROCESSOR_ERROR_MSG from the v2 wiki pages or add a note explaining that they are deprecated.

I also think they should be removed from the v3 wiki pages.

Activity

  1. airween commented on Jun 16, 2026

    @airween
    Member

    Hi @hnakamur,

    probably you're right. But we have to investigate the current behavior, it seems like those variables are still in use, see this part.

    (I just took a quick look, but may be the logic is wrong there, because if the error.empty() is false, then transactions sets those variables, but if it's empty, then it resets the REQBODY_ERROR variable. And only that one.)

    @dune73 do you have any idea why they made these mentioned variables deprecated? It seems like it was a name change...

  2. hnakamur commented on Jun 16, 2026

    @hnakamur
    ContributorAuthor

    Hi @airween,
    Yes, it is still in use in v3, but not in v2. So I think we would deprecate them in v3 too.

  3. airween commented on Jun 16, 2026

    @airween
    Member

    Hi @airween, Yes, it is still in use in v3, but not in v2. So I think we would deprecate them in v3 too.

    I've been working on v4, first PR's will arrive soon. May be we should remove them there.

  4. airween commented on Jun 16, 2026

    @airween
    Member

    Hi @hnakamur,

    I checked these variables in v2 and it seems they are still part of it.

    I suggest to remove them from both version, then remove from the documentation.

    Note, that if v4 will be released, I have a plan to release v2.10 - then we can allow some more changes, I guess.

  5. added
    2.xRelated to ModSecurity version 2.x
    on Jun 16, 2026
  6. hnakamur commented on Jun 16, 2026

    @hnakamur
    ContributorAuthor

    Hi @airween,

    Thank you for pointing out that REQBODY_PROCESSOR_ERROR and REQBODY_PROCESSOR_ERROR_MSG are still used in v2.

    However their values are always the same as new REQBODY_ERROR and REQBODY_ERROR_MSG respectively since the REQBODY_PROCESSOR_ERROR and REQBODY_ERROR share the same variable generation function. The same is true for REQBODY_PROCESSOR_ERROR_MSG and REQBODY_ERROR_MSG.

    Therefore, we can simply use REQBODY_ERROR and REQBODY_ERROR_MSG instead of REQBODY_PROCESSOR_ERROR and REQBODY_PROCESSOR_ERROR_MSG.

    I searched for REQBODY_PROCESSOR_ERROR in the coreruleset repository:

    https://github.com/search?q=repo%3Acoreruleset%2Fcoreruleset%20REQBODY_PROCESSOR_ERROR&type=code

    There is only one occurrence, in CHANGES.md, so there are no actual references to REQBODY_PROCESSOR_ERROR or REQBODY_PROCESSOR_ERROR_MSG in the rules themselves.

    So I agree that we should remove REQBODY_PROCESSOR_ERROR and REQBODY_PROCESSOR_ERROR_MSG, and I've opened a PR: #3578

  7. hnakamur commented on Jun 17, 2026

    @hnakamur
    ContributorAuthor

    I am also trying to create a PR for v3:
    a22fd2e

    However, I don't know how to update src/parser/seclang-parser.cc after modifying src/parser/seclang-parser.yy.
    I expected it to be regenerated by running make, but it wasn't (please see the ls -l src/parser output in the commit message).

  8. hnakamur commented on Jun 17, 2026

    @hnakamur
    ContributorAuthor

    I updated src/parser/seclang-parser.cc by hand and opened a PR for v3: #3579

  9. airween commented on Jun 17, 2026

    @airween
    Member

    However, I don't know how to update src/parser/seclang-parser.cc after modifying src/parser/seclang-parser.yy.

    After you changed the lexer (.ll) and syntax checker (.yy) files, you should run

    ./configure --enable-parser-generation ....
    

    This will generate src/parser/seclang-parser.cc, src/parser/seclang-parser.hh, src/parser/seclang-scanner.cc and other necessary files. Then you can add them to the commit.

  10. hnakamur commented on Jun 17, 2026

    @hnakamur
    ContributorAuthor

    Thank you! I added the commit af27f12 to #3579

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    2.xRelated to ModSecurity version 2.x

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions