-
Notifications
You must be signed in to change notification settings - Fork 138
[feature/kiteworks-build] Kiteworks Integration #1479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ownCloud/Resources/Theming/com.owncloud.ios-app.kiteworks/Branding.plist
Outdated
Show resolved
Hide resolved
ownCloud/Resources/Theming/com.owncloud.ios-app.kiteworks/Branding.plist
Outdated
Show resolved
Hide resolved
ownCloud/Resources/Theming/com.owncloud.ios-app.kiteworks/Branding.plist
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed all Code Review findings in separate commits.
…en rebase merge conflicts - changes originally made by: Co-authored-by: Matthias Hühne <[email protected]>
ff42c7c
to
916f5cc
Compare
… then cancel at login, then enter an ownCloud server URL, leading to a server-side error due to wrong client ID/secret
(1) [FIXED]Checking the authentication process against server
client_id is missing in the request payload, which only includes:
iPhone XR IoS 18.4 |
@jesmrec Please check if the latest commit fixes the issue. Since I have no test credentials, I can't verify myself. |
(1) is fixed |
Some QA checks:
** copy, move and rename don't work (known problem) |
(2) [FIXED]I realised that weird effect:
Current: All spaces are named Expected: Correct space names Video (Personals are called "MyPersonal", "test1" and "test2"): screenrecording-07-29-2025-14-04-58-1_hKy4AtTO.mp4iPhoneXR iOS 18.4 |
(2) fixed |
Approved, good job! |
a200664
to
b569a2e
Compare
f13317e
to
2e7bed0
Compare
…3IUF library copy contained in ios-sdk - update ios-sdk
9f4c72f
to
436d6f4
Compare
The found issue has since been resolved. Dismissing the review to move forward with merging.
Description
This PR adds Kiteworks integration to the iOS ownCloud app.
The SDK was adopted to detect a Kiteworks server and proceed with the needed logic.
The iOS app got some adoption regarding sidebar items and not to show folder sizes (as it is not available on Kiteworks server).
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
QA
Reports