Skip to content

Conversation

Matthias-Huehne-Kiteworks
Copy link
Contributor

@Matthias-Huehne-Kiteworks Matthias-Huehne-Kiteworks commented Jul 21, 2025

Description

This PR adds Kiteworks integration to the iOS ownCloud app.
The SDK was adopted to detect a Kiteworks server and proceed with the needed logic.

The iOS app got some adoption regarding sidebar items and not to show folder sizes (as it is not available on Kiteworks server).

Related Issue

Motivation and Context

How Has This Been Tested?

  • login wih a Kiteworks (Test-)server URL
  • login with an ownCloud server URL (to check if ownCloud login is still working)

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • Added an issue with details about all relevant changes in the iOS documentation repository.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • Added changelog files for the fixed issues in folder changelog/unreleased

QA

Reports

@CLAassistant
Copy link

CLAassistant commented Jul 21, 2025

CLA assistant check
All committers have signed the CLA.

@hosy hosy requested a review from felix-schwarz July 22, 2025 08:36
Copy link
Contributor

@felix-schwarz felix-schwarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed all Code Review findings in separate commits.

…en rebase merge conflicts

- changes originally made by:
Co-authored-by: Matthias Hühne <[email protected]>
@felix-schwarz felix-schwarz force-pushed the feature/kiteworks-build branch from ff42c7c to 916f5cc Compare July 28, 2025 13:33
… then cancel at login, then enter an ownCloud server URL, leading to a server-side error due to wrong client ID/secret
@jesmrec
Copy link
Contributor

jesmrec commented Jul 28, 2025

(1) [FIXED]

Checking the authentication process against server https://client-testing.....ru/, the POST request to get the token (/oauth/token) returns 422 (Unprocessable Content client error) with the following payload:

{
    "errors": [
        {
            "code": "ERR_INVALID_PARAMETER",
            "field": "client_id",
            "message": "Missing data for required field."
        }
    ]
}

client_id is missing in the request payload, which only includes:

code:  ...
code_verifier:  ...
redirect_uri: ...
grant_type: ...

iPhone XR IoS 18.4
b5479b8de3

@felix-schwarz
Copy link
Contributor

@jesmrec Please check if the latest commit fixes the issue. Since I have no test credentials, I can't verify myself.

@felix-schwarz felix-schwarz requested a review from jesmrec July 29, 2025 06:55
@jesmrec
Copy link
Contributor

jesmrec commented Jul 29, 2025

(1) is fixed

@jesmrec
Copy link
Contributor

jesmrec commented Jul 29, 2025

Some QA checks:

  • Kiteworks token granted
  • oCIS token granted
  • oC10 token granted
  • Kiteworks token renewed
  • oCIS token renewed
  • oC10 token renewed
  • Check basic operations in kiteworks (create folder, delete, upload, download)

** copy, move and rename don't work (known problem)

@jesmrec
Copy link
Contributor

jesmrec commented Jul 29, 2025

(2) [FIXED]

I realised that weird effect:

  1. Add Kiteworks account -> list of personal spaces is correct
  2. Kill the app
  3. Open the app
  4. Check the list of personal spaces

Current: All spaces are named Personal

Expected: Correct space names

Video (Personals are called "MyPersonal", "test1" and "test2"):

screenrecording-07-29-2025-14-04-58-1_hKy4AtTO.mp4

iPhoneXR iOS 18.4
cf9b806562

@jesmrec
Copy link
Contributor

jesmrec commented Jul 29, 2025

(2) fixed

@jesmrec
Copy link
Contributor

jesmrec commented Jul 29, 2025

Approved, good job!

@jesmrec jesmrec added the Approved by QA Approved by QA label Jul 29, 2025
@felix-schwarz felix-schwarz force-pushed the feature/kiteworks-build branch 4 times, most recently from a200664 to b569a2e Compare July 30, 2025 09:22
@felix-schwarz felix-schwarz force-pushed the feature/kiteworks-build branch 4 times, most recently from f13317e to 2e7bed0 Compare July 30, 2025 09:55
@felix-schwarz felix-schwarz force-pushed the feature/kiteworks-build branch from 9f4c72f to 436d6f4 Compare July 30, 2025 10:07
@felix-schwarz felix-schwarz dismissed DeepDiver1975’s stale review July 30, 2025 10:23

The found issue has since been resolved. Dismissing the review to move forward with merging.

@felix-schwarz felix-schwarz merged commit b345a72 into master Jul 30, 2025
6 checks passed
@felix-schwarz felix-schwarz deleted the feature/kiteworks-build branch July 30, 2025 10:23
@jesmrec jesmrec mentioned this pull request Aug 7, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved by QA Approved by QA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants