Skip to content

Apiv2 #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Apiv2 #153

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
1a6705f
Add notification API v2 for better handling of the notifications
jvillafanez Mar 9, 2018
26743b5
Add tests for the new API
jvillafanez Mar 20, 2018
268f243
Adjust the OC-Last-Notification header to return -1 if no notification
jvillafanez Mar 22, 2018
20bfa16
WebUI uses v2 API
jvillafanez Mar 22, 2018
4a208ae
Use OCSResponse instead of JSONResponse
jvillafanez Mar 26, 2018
2895cac
Adjust tests and fix code
jvillafanez Mar 26, 2018
dee945f
Increase code coverage
jvillafanez Mar 27, 2018
add27d7
Fix oracle identifier
jvillafanez Mar 27, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 37 additions & 4 deletions appinfo/routes.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,41 @@
],

'routes' => [
['name' => 'NotificationOptions#getNotificationOptions', 'url' => '/settings/personal/notifications/options', 'verb' => 'GET'],
['name' => 'NotificationOptions#setNotificationOptions', 'url' => '/settings/personal/notifications/options', 'verb' => 'PUT'],
['name' => 'NotificationOptions#setNotificationOptionsPartial', 'url' => '/settings/personal/notifications/options', 'verb' => 'PATCH'],
],
[
'name' => 'NotificationOptions#getNotificationOptions',
'url' => '/settings/personal/notifications/options',
'verb' => 'GET'
],
[
'name' => 'NotificationOptions#setNotificationOptions',
'url' => '/settings/personal/notifications/options',
'verb' => 'PUT'
],
[
'name' => 'NotificationOptions#setNotificationOptionsPartial',
'url' => '/settings/personal/notifications/options',
'verb' => 'PATCH'
],

[
'name' => 'EndpointV2#listNotifications',
'url' => '/api/v2/notifications',
'verb' => 'GET'
],
[
'name' => 'EndpointV2#getNotification',
'url' => '/api/v2/notifications/{id}',
'verb' => 'GET'
],
[
'name' => 'EndpointV2#deleteNotification',
'url' => '/api/v2/notifications/{id}',
'verb' => 'DELETE'
],
[
'name' => 'EndpointV2#getLastNotificationId',
'url' => '/api/v2/tracker/notifications/polling',
'verb' => 'GET'
],
]
];
8 changes: 8 additions & 0 deletions css/styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,14 @@
font-size: 16px;
}

.notification-container .notification-controls {
text-align: center;
}

.notification-container .notification-controls button {
display: inline;
}

/* Fill width on mobile */
@media (max-width: 500px) {
.notification-container {
Expand Down
Loading