Skip to content

feat(minifier): support more statements for single use variable inlining #13277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 24, 2025
Merged

feat(minifier): support more statements for single use variable inlining #13277

merged 1 commit into from
Aug 24, 2025

Conversation

sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Aug 24, 2025 •
edited
Loading

Added substitute_single_use_symbol_in_statement calls to other statements like esbuild does.

This was referenced Aug 24, 2025
Merged
Merged
Merged
Merged
@sapphi-red Graphite App
Copy link
Member Author

sapphi-red commented Aug 24, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@sapphi-red sapphi-red mentioned this pull request Aug 24, 2025
Merged
@github-actions github-actions bot added A-minifier Area - Minifier C-enhancement Category - New feature or request labels Aug 24, 2025
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Aug 24, 2025 •
edited
Loading

CodSpeed Instrumentation Performance Report

Merging #13277 will degrade performances by 7.21%

Comparing 08-24-feat_minifier_support_more_statements_for_single_use_variable_inlining (a951eee) with main (e7a49ed)1

Summary

❌ 1 regressions
✅ 33 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
❌ minifier[react.development.js] 2.1 ms 2.3 ms -7.21%

Footnotes

  1. No successful run was found on 08-24-feat_minifier_support_more_expressions_for_single_use_variable_inlining (dcda3a2) during the generation of this report, so main (e7a49ed) was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@sapphi-red sapphi-red force-pushed the 08-24-feat_minifier_support_more_expressions_for_single_use_variable_inlining branch from b70e401 to 62e38f5 Compare August 24, 2025 06:04
@sapphi-red sapphi-red force-pushed the 08-24-feat_minifier_support_more_statements_for_single_use_variable_inlining branch from 1dac1a4 to 17cf2c7 Compare August 24, 2025 06:04
@sapphi-red sapphi-red mentioned this pull request Aug 24, 2025
Merged
@sapphi-red sapphi-red force-pushed the 08-24-feat_minifier_support_more_statements_for_single_use_variable_inlining branch from 17cf2c7 to 45df7a8 Compare August 24, 2025 06:39
@sapphi-red sapphi-red force-pushed the 08-24-feat_minifier_support_more_expressions_for_single_use_variable_inlining branch 2 times, most recently from 95082cd to da5d1f9 Compare August 24, 2025 06:43
@sapphi-red sapphi-red force-pushed the 08-24-feat_minifier_support_more_statements_for_single_use_variable_inlining branch from 45df7a8 to 9e407ff Compare August 24, 2025 06:43
@sapphi-red sapphi-red marked this pull request as ready for review August 24, 2025 07:03
This was referenced Aug 24, 2025
Merged
Merged
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Aug 24, 2025
@graphite-app Graphite App
Copy link
Contributor

graphite-app bot commented Aug 24, 2025 •
edited
Loading

Merge activity

@sapphi-red
feat(minifier): support more statements for single use variable inlin…
a951eee 
…ing (#13277)

Added `substitute_single_use_symbol_in_statement` calls to other statements like esbuild does.
@graphite-app graphite-app bot force-pushed the 08-24-feat_minifier_support_more_expressions_for_single_use_variable_inlining branch from da5d1f9 to dcda3a2 Compare August 24, 2025 08:45
@graphite-app graphite-app bot force-pushed the 08-24-feat_minifier_support_more_statements_for_single_use_variable_inlining branch from 9e407ff to a951eee Compare August 24, 2025 08:46
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Aug 24, 2025
Base automatically changed from 08-24-feat_minifier_support_more_expressions_for_single_use_variable_inlining to main August 24, 2025 08:53
@graphite-app graphite-app bot merged commit a951eee into main Aug 24, 2025
26 checks passed
@graphite-app graphite-app bot deleted the 08-24-feat_minifier_support_more_statements_for_single_use_variable_inlining branch August 24, 2025 08:54
@oxc-bot oxc-bot mentioned this pull request Aug 29, 2025
Merged
@sapphi-red sapphi-red mentioned this pull request Sep 14, 2025
Merged
graphite-app bot pushed a commit that referenced this pull request Sep 14, 2025
@sapphi-red
feat(minifier): support ForStatements for single use variable inlining (
c364ad1 
#13755)

Inline single use variables in for statements:
```js
function wrapper1() { var x = foo; for (var i = x; i < 10; i++) console.log(i) }
function wrapper2() { var i, x = foo; for (i = x; i < 10; i++) console.log(i) }
// to
function wrapper1() { for (var i = foo; i < 10; i++) console.log(i) }
function wrapper2() { var i; for (i = foo; i < 10; i++) console.log(i) }
```
```js
function wrapper() { var x = {}; for (var a in x) console.log(a) }
// to
function wrapper() { for (var a in {}) console.log(a) }
```
```js
function wrapper() { var x = []; for (var a of x) console.log(a) }
// to
function wrapper() { for (var a of []) console.log(a) }
```

refs #13277
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-minifier Area - Minifier C-enhancement Category - New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sapphi-red