Support for runtime metaprogramming #121
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dreian
force-pushed
the
runtime-metaprogramming
branch
2 times, most recently
from
204aad5 to
535f727
Compare
Dreian
force-pushed
the
runtime-metaprogramming
branch
from
535f727 to
3acbc08
Compare
ccasin
reviewed
Oct 15, 2025
|
|
||
| let double = | ||
| <[let x = <[42]> in | ||
| <[123 + $x]>]> |
There was a problem hiding this comment.
I think we need more thorough tests of the kinds of things that usually trip ocamlformat up:
- quotes/spices of very long identifiers, splices split over multiple lines
- Every way a comment can interact with a piece of metaprogramming syntax
- Every way an attribute can interact with a piece of metaprogramming syntax
It may be instructive to look at @dvulakh's recent test for block indices for the kind of thoroughness we aim for. This may seem like overkill, but in practice we generally find that such tests catch bugs.
ccasin
reviewed
Oct 15, 2025
| and syntax_directive = | ||
| { | ||
| psyn_mode: string loc; | ||
| psyn_toggle: bool; |
There was a problem hiding this comment.
It's not obvious to me what psyn_mode and psyn_toggle represent - maybe a comment?
vendor/parser-standard/parsetree.mli
Outdated
| { | ||
| plex_desc: lexer_directive_desc; | ||
| plex_loc: Location.t | ||
| } |
There was a problem hiding this comment.
It's not immediately obvious to me that we need to add these bits to parser-standard, since I think it is not used for printing. But maybe I'm failing to consider some aspect of the round trip tests?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for formatting runtime quotations and splices to ocamlformat.
The appropriate changes are added to the lexing, parsing, and formatting.
At the level of individual files, runtime metaprogramming can be enabled or disabled using a syntax directive:
#syntax quotations [on|off]. This requires that we add such directives as a construct that does not lead to an error in the lexer; in fact, it has to get propagated through the parser and the formatter. These lexer directives are represented using the newlexer_directivetype.