fix js_of_ocaml patches #11
Merged
+25
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting, the package is installing fine for me. What OS, opam version and patch version are you using? |
|
I'm seeing breakage on macOS with opam 2.4.1 I think that now has a builtin patch, so this might be a regression ; /cc @kit-ty-kate |
|
FWIW I'm using opam 2.3.0 on macos, which is using gpatch, and the patches apply cleanly. |
kit-ty-kate
reviewed
Sep 11, 2025
| @@ -1,10 +1,9 @@ | |||
| --- a/runtime/js/array.js | |||
| +++ b/runtime/js/array.js | |||
| @@ -131,3 +131,13 @@ | |||
| for (var i = 1; i < len; i++) b[i] = 0; | |||
| return b | |||
There was a problem hiding this comment.
I'm not exactly sure how GNU Patch allowed that if that's not what the file looks like. Could someone open a ticket on https://github.com/hannesm/patch/issues with state of this file before the patch and a link to the original patch? If no-one has the spare time to do it, i'll do it sometime later this week
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Installation of js_of_ocaml was previously failing due to a bad patch. This PR fixes that. After updating the patch, I'm able to successfully install js_of_ocaml.