Replace Listbox in Create Disk side modal with Combobox #2829
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Thank you! We will take a look soon. |
| isLoading={areImagesLoading} | ||
| items={images.map((i) => toImageComboboxItem(i, true))} | ||
| required | ||
| onInputChange={() => { | ||
| diskImageIdField.onChange() | ||
| }} |
There was a problem hiding this comment.
It allows the modification of the underlying text value after the selection of one item, otherwise, the text value changes only by selecting another item in the list and not by input events.
There was a problem hiding this comment.
Makes sense, and good catch. I think you can move this fix to the ComboboxField component by adding an onInputChange={() => field.onChange()} to the main Combobox props, fixing it for all Comboboxes.
It does seem like there's a funny interaction where selecting an option, then deleting some of the contents, then blurring the field by clicking outside the component then erases the selected option. Would there be a way to prevent that selected option from getting lost?
There was a problem hiding this comment.
Sounds good, I'll prepare a change for this.
For the first item: I'm guessing we should destructure onInputChange from the ComboboxField props and call it in a similar fashion as onChange (e.g. onInputChange?.(value)), right?
There was a problem hiding this comment.
Sorry for dropping this; yes, good call! Adding onInput Change to the ComboboxField props and calling something like
onInputChange={(value) => {
field.onChange()
onInputChange?.(value)
}}
makes sense to me so we don't swallow anything passed through. Is that about what you were thinking?
This replaces the Listbox in snapshot and image source selections with a Combobox. Solving (hopefully) #2827.
combobox.mp4