Skip to content

CI with smaller mac runner #2856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

CI with smaller mac runner #2856

wants to merge 8 commits into from

Conversation

david-crespo
Copy link
Collaborator

@david-crespo david-crespo commented Jul 14, 2025

I have been informed that the large Mac runners are powered by gerbils that refuse to eat anything but hundred dollar bills.

https://docs.github.com/en/billing/managing-billing-for-your-products/about-billing-for-github-actions

Copy link

vercel bot commented Jul 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
console ✅ Ready (Inspect) Visit Preview Jul 18, 2025 2:30am

@david-crespo
Copy link
Collaborator Author

The tests that failed in Safari this time

  3 failed
    [safari] › test/e2e/floating-ip-create.e2e.ts:56:1 › can detach and attach a floating IP ───────
    [safari] › test/e2e/instance-create.e2e.ts:40:1 › can create an instance ───────────────────────
    [safari] › test/e2e/instance-networking.e2e.ts:18:1 › Instance networking tab — NIC table ──────
  6 flaky
    [safari] › test/e2e/click-everything.e2e.ts:14:1 › Click through instance page ─────────────────
    [safari] › test/e2e/instance-create.e2e.ts:148:1 › first preset is auto-selected in each tab ───
    [safari] › test/e2e/instance-metrics.e2e.ts:37:1 › Instance metrics work for non-fleet viewer ──
    [safari] › test/e2e/instance-serial.e2e.ts:12:1 › serial console can connect while starting ────
    [safari] › test/e2e/lookup-routes.e2e.ts:38:3 › /lookup/instances › looks up instance by ID ────
    [safari] › test/e2e/vpcs.e2e.ts:279:1 › edit and delete router route ───────────────────────────
  12 skipped
  174 passed (14.5m)

are almost completely different from the first time

   5 failed
    [safari] › test/e2e/firewall-rules.e2e.ts:534:1 › can edit rule directly by URL ────────────────
    [safari] › test/e2e/instance-auto-restart.e2e.ts:47:1 › Auto restart policy on running instance 
    [safari] › test/e2e/instance-networking.e2e.ts:18:1 › Instance networking tab — NIC table ──────
    [safari] › test/e2e/instance-networking.e2e.ts:103:1 › Instance networking tab — Detach / Attach Ephemeral IPs 
    [safari] › test/e2e/instance-networking.e2e.ts:138:1 › Instance networking tab — floating IPs ──
  6 flaky
    [safari] › test/e2e/instance-metrics.e2e.ts:15:1 › Click through instance metrics ──────────────
    [safari] › test/e2e/instance-metrics.e2e.ts:37:1 › Instance metrics work for non-fleet viewer ──
    [safari] › test/e2e/instance-serial.e2e.ts:12:1 › serial console can connect while starting ────
    [safari] › test/e2e/instance.e2e.ts:157:1 › can resize a failed or stopped instance ────────────
    [safari] › test/e2e/lookup-routes.e2e.ts:38:3 › /lookup/instances › looks up instance by ID ────
    [safari] › test/e2e/vpcs.e2e.ts:364:1 › internet gateway shows proper list of routes targeting it 
  12 skipped
  172 passed (15.0m)

so file that under Bullshit That Might Be Fixed By More Cores. The test trace I checked shows it failing because the page takes over 10 seconds to load.

image

@david-crespo david-crespo changed the title CI with linux runners CI with smaller mac runner Jul 18, 2025
@david-crespo
Copy link
Collaborator Author

Until @augustuswm can get me a bigger but not too big linux runner, we can at least switch back to the standard mac one, which costs about half as much, though it takes nearly twice as long, so it might be kind of a wash.

@david-crespo
Copy link
Collaborator Author

Haha well. If the smaller runner has a bunch of flakes slowing down the tests, it's actually cheaper to use the bigger one (assuming I am reading the prices right and it's double the price).

macos-15-xlarge

Total: 15 minutes

image

macos-15

Total: 34 minutes

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants