Skip to content

Conversation

@charliepark
Copy link
Contributor

@charliepark charliepark commented Oct 15, 2025

This sets up the system management UI to handle SCIM tokens.
Screenshot 2025-10-15 at 7 05 11 AM
Screenshot 2025-10-15 at 7 05 17 AM
Screenshot 2025-10-15 at 7 05 24 AM

A few outstanding things to note:

Closes #2886

@vercel
Copy link

vercel bot commented Oct 15, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
console Ready Ready Preview Oct 27, 2025 0:10am

</div>
<div className="border-default border-l p-3">
<CopyToClipboard text={token.bearerToken} />
</div>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think we need design polish from @benjaminleonard. I'd put the yellow bit at the top, for one. Maybe put the expiration at the bottom and display it in one line. Could do without the pseudo form field styling.

Image

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

heh just kidding. it's a lot closer to the design than I expected. The pseudo-input it too tall though.

image

@david-crespo
Copy link
Collaborator

UX looks great! The only thing that feels a little off is that the expiration time is mysterious — where is it coming from? This is the admin UI, so it would be weird for it to be outside their control. Maybe in production there would not be a mix of expires: never and expires: sometime.

@david-crespo
Copy link
Collaborator

Ah. It appears the expiration logic is as yet undetermined and I am supposed to be the one reviewing that PR.

https://github.com/oxidecomputer/omicron/pull/9180/files#diff-66828e0806cce09d9bc202d280a93e736c7f18d694fa1c003ca685e1b7f7a104R69-R70

image

@charliepark
Copy link
Contributor Author

charliepark commented Oct 15, 2025

If we don't pass in a time in the mock service worker it defaults to Never, so I can run with that. In the Product Roundtable on Monday someone threw out 90 days, but I think that was just a ¯\_(ツ)_/¯

@charliepark
Copy link
Contributor Author

Also, without the expiration time we can comment out the Expires block above the yellow box for now, which will make it look less sandwich-y. Or just delete it entirely and add it back in at whatever point expiration times become configurable.

@charliepark
Copy link
Contributor Author

Slight update to remove the "expires" column from the table (also from the post-creation modal).
Screenshot 2025-10-15 at 3 27 49 PM
Tokens will not have an expiration date.

@charliepark
Copy link
Contributor Author

Most recent change gives a width to the "Expires" column. When it had actual datetimes it looked somewhat normal, but with just the badge it was showing up like this:
Screenshot 2025-10-15 at 8 21 16 PM
So this commit gives the table this look on desktops:
Screenshot 2025-10-15 at 8 25 34 PM

@benjaminleonard
Copy link
Contributor

I did one last design pass, so consider it good to go in that aspect

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Want SCIM bearer token CRD UI

3 participants