Skip to content

Conversation

@mkeeter
Copy link
Contributor

@mkeeter mkeeter commented Nov 6, 2025

This is a draft for debugging purposes

@mkeeter mkeeter requested a review from leftwo November 6, 2025 17:32
Copy link
Contributor

@leftwo leftwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this, we are checking both on open and just after receiving, right? We again will catch problems on startup or on LR

@mkeeter mkeeter force-pushed the mkeeter/single-block-validation branch from 5d41257 to 51794d4 Compare November 6, 2025 19:49
@mkeeter
Copy link
Contributor Author

mkeeter commented Nov 6, 2025

For this, we are checking both on open and just after receiving, right? We again will catch problems on startup or on LR

Yeah, that's the intention:

  • We verify the extent after receiving it (but before copying it into place)
  • In addition, we verify the extent as part of Extent::open. This is called when initially opening the extent, and also when re-opening after a repair. If we panic in that case, the backtrace should tell us where it's coming from.

"Verify" here means just checking block 0, because that's a cheap test for the issue seen in #1788.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants