[WIP] MAX5980 12V output rail sag ereport #2182
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, `snitc-core` will panic on reads if we have lost data and there is no space for an additional loss record in the buffer. This is because reads while the store is in the `Losing` state will attempt to insert a loss record to report that data has been lost. However, if there is no space in the queue, inserting the loss record will panic. This commit fixes this by reserving space for one additional loss record at all times. We will no longer admit new messages into the buffer if they mean we cannot encode a loss record when more messages come in. This, unfortunately, means that we can no longer admit entries that fill the entire queue, due to this reservation.
This reverts commit 0b8e1ed.
previously, we had a ringbuf entry that contained both the current and requested restart IDs, and was therefore 256B --- meaning the ringbuf was an array of 16 entries that were at least 257B each (including the enum discriminant). that's like 4KiB of ringbuf, which is quite uncomfortable. by moving things around a bit so that we have separate entries for "we got a request with this restart ID" and "restart IDs didn't match", we can make the max sized ringbuf entry 128B (plus an enum discriminant), which basically cuts the size of the ringbuf in half.
this is intended to help test cases where ereports are generated before VPD is set.
that should save a byte or so...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.