Add desired host phase 2 contents to OmicronSledConfig (PR 1/4)
#8538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 8, 2025
jgallagher
commented
Jul 8, 2025
| host_phase_2: HostPhase2DesiredSlots::current_contents(), | ||
| }; | ||
|
|
||
| // TODO-john also test host phase 2 artifacts! |
There was a problem hiding this comment.
This and its friend below are both addressed in #8539
andrewjstone
approved these changes
Jul 8, 2025
| pub generation: Generation, | ||
| pub remove_mupdate_override: Option<DbTypedUuid<MupdateOverrideKind>>, | ||
|
|
||
| #[diesel(embed)] |
jgallagher
added a commit
that referenced
this pull request
Jul 15, 2025
This is a followup to the stack of PRs that added desired host phase 2 contents to `OmicronSledConfig` (#8538 and its followups). We now have a `BlueprintHostPhase2DesiredSlots` inside each `BlueprintSledConfig` that specifies the desired contents (artifact by hash-and-version or "just the current contents", analogous to the install dataset for zones) for each of the two phase 2 slots.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HostPhase2DesiredContentsis analogous toOmicronZoneImageSource, but for OS images: either keep the current contents of the boot disk or set it to a specific artifact from the TUF repo depot. "Keep the current contents" should show up in three cases, just likeOmicronZoneImageSource::InstallDataset: