Skip to content

Support Bundles: Add user comment support #8582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 18, 2025
Merged

Support Bundles: Add user comment support #8582

merged 1 commit into from
Jul 18, 2025

Conversation

smklein
Copy link
Collaborator

@smklein smklein commented Jul 11, 2025

Adds a text field for support bundles, letting users supply string labels as comments

Fixes #8550

@smklein smklein changed the title Support Bundle: Add user comment support Support Bundles: Add user comment support Jul 11, 2025
@smklein smklein force-pushed the bundle-comment branch 4 times, most recently from d0f3439 to eda9b97 Compare July 11, 2025 19:46
@smklein smklein requested a review from papertigers July 17, 2025 18:30
@papertigers
Copy link
Contributor

I have to take a closer look still but one thought that comes to mind is that it would be nice if you could pass the comment on create oxide bundle create --comment "VM stuck in starting". If we choose to punt on that we should at least file a follow up ticket.

@smklein smklein force-pushed the bundle-comment branch 6 times, most recently from 5a75f71 to e7c7683 Compare July 17, 2025 23:59
@smklein
Copy link
Collaborator Author

smklein commented Jul 18, 2025

I have to take a closer look still but one thought that comes to mind is that it would be nice if you could pass the comment on create oxide bundle create --comment "VM stuck in starting". If we choose to punt on that we should at least file a follow up ticket.

Sure thing, added this to the CREATE endpoint, alongside some tests

Copy link

@askfongjojo askfongjojo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you for adding the update method as well.

@smklein smklein merged commit 53aea85 into main Jul 18, 2025
17 checks passed
@smklein smklein deleted the bundle-comment branch July 18, 2025 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow user to enter an optional comment for a support bundle
3 participants