[33/n] [nexus-types] add displayers for zone image resolver status #8619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.6-beta.1 [skip ci]
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1
jgallagher
approved these changes
Jul 17, 2025
Comment on lines
+358
to
+361
| let f = indented.into_inner(); | ||
|
|
||
| writeln!(f, "mupdate override:")?; | ||
| let mut indented = IndentWriter::new(" ", f); |
There was a problem hiding this comment.
Could get a ref to the inner writer to avoid needing to recreate indented?
Suggested change
| let f = indented.into_inner(); | |
| writeln!(f, "mupdate override:")?; | |
| let mut indented = IndentWriter::new(" ", f); | |
| writeln!(indented.get_ref(), "mupdate override:")?; |
Maybe that's actually less clear though. Your call
There was a problem hiding this comment.
get_ref returns a shared reference, but we need a mutable ref here unfortunately.
sunshowers
changed the base branch from
sunshowers/spr/main.33n-nexus-types-add-displayers-for-zone-image-resolver-status
to
main
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1
sunshowers
deleted the
sunshowers/spr/33n-nexus-types-add-displayers-for-zone-image-resolver-status
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Realized that we were missing displayers for the zone image resolver. Write these out, and also test them through reconfigurator-cli via the beginnings of a test for the mupdate/update flow.
Depends on: