[reconfigurator-cli] RoT bootloader support

[karencfv]

Equivalent of #8273 for RoT bootloader

[sunshowers]

Thanks -- a few questions.

[sunshowers]

What does Option mean here -- i.e. under what circumstances is it possible to return None? And can this return an &ArtifactVersion to match what sled_update_rot_bootloader_versions accepts?

[karencfv]

Being honest, I was just copying what @davepacheco had done for the SP

omicron/nexus/reconfigurator/planning/src/system.rs

Lines 518 to 526 in 2b32fc6

	pub fn sled_sp_active_version(
	&self,
	sled_id: SledUuid,
	) -> anyhow::Result<Option<&str>> {
	let sled = self.sleds.get(&sled_id).with_context(|| {
	format!("attempted to access sled {} not found in system", sled_id)
	})?;
	Ok(sled.sp_active_caboose().map(|c| c.version.as_ref()))
	}

That said, I think I have an idea as to why he did it this way. These methods are only used for the cmd_sled_show function. If I were to return ArtifactVersion, then I would have to parse the result back to a string within the cmd_sled_show function, otherwise the output would look like this:

RoT bootloader stage 0 version:   Some(ArtifactVersion("0.0.1"))

instead of:

omicron/dev-tools/reconfigurator-cli/tests/output/cmds-example-stdout

Lines 43 to 44 in 2b32fc6

	SP active version: Some("0.0.1")
	SP inactive version: None

As to why he used an option, I'm not entirely sure. I'd like to keep it like this for now, just so it matches what the SP does. When @davepacheco comes back, I'll ask him why it was an option in the first place, and happy to change it if it'd be better to not have the Option. WDYT?

[sunshowers]

Is the & required here and in stage0_next_caboose below?

[karencfv]

aha! it is not 😄

[sunshowers]

same q here I guess -- can we prefill these values to something reasonable? In production we always have these filled out, right?

[karencfv]

Same as above, I'd like to ask @davepacheco why it was done this way with the SPs to begin with

[karencfv]

Thanks for taking the time to review!

[karencfv]

Being honest, I was just copying what @davepacheco had done for the SP

omicron/nexus/reconfigurator/planning/src/system.rs

Lines 518 to 526 in 2b32fc6

	pub fn sled_sp_active_version(
	&self,
	sled_id: SledUuid,
	) -> anyhow::Result<Option<&str>> {
	let sled = self.sleds.get(&sled_id).with_context(|| {
	format!("attempted to access sled {} not found in system", sled_id)
	})?;
	Ok(sled.sp_active_caboose().map(|c| c.version.as_ref()))
	}

That said, I think I have an idea as to why he did it this way. These methods are only used for the cmd_sled_show function. If I were to return ArtifactVersion, then I would have to parse the result back to a string within the cmd_sled_show function, otherwise the output would look like this:

RoT bootloader stage 0 version:   Some(ArtifactVersion("0.0.1"))

instead of:

omicron/dev-tools/reconfigurator-cli/tests/output/cmds-example-stdout

Lines 43 to 44 in 2b32fc6

	SP active version: Some("0.0.1")
	SP inactive version: None

As to why he used an option, I'm not entirely sure. I'd like to keep it like this for now, just so it matches what the SP does. When @davepacheco comes back, I'll ask him why it was an option in the first place, and happy to change it if it'd be better to not have the Option. WDYT?

[karencfv]

aha! it is not 😄

[karencfv]

Same as above, I'd like to ask @davepacheco why it was done this way with the SPs to begin with