[nexus] Update status API #8897
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgallagher
reviewed
Aug 25, 2025
| ); | ||
|
|
||
| let zone_versions = status | ||
| .zones |
There was a problem hiding this comment.
FYI #8901 changes the status struct to add information about other components. I think git may not realize it conflicts, but it definitely does - sorry! (Fundamentally it's still the same "list of components and their versions", but some of the other components are slightly more complicated to report, and there are weird failure cases; e.g., we could know which disk a sled booted from but not what's on it, or know what's on both disks but not which it booted from, etc.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8869.
WIP. Noodled around until I got something that is not entirely garbage. This endpoint works without calling any of the methods that are designed to bail if you are in the external API.
To do