(4/N) db_metadata_nexus queries (handoff) #8932
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smklein
changed the title
smklein
force-pushed
the
db_metadata_nexus_handoff
branch
from
c3be777 to
c289efd
Compare
smklein
force-pushed
the
db_metadata_nexus_queries
branch
from
20fafc3 to
b884dfa
Compare
smklein
force-pushed
the
db_metadata_nexus_handoff
branch
from
c289efd to
7d2b6e1
Compare
smklein
changed the title
smklein
force-pushed
the
db_metadata_nexus_queries
branch
from
b884dfa to
a91fb35
Compare
smklein
force-pushed
the
db_metadata_nexus_handoff
branch
2 times, most recently
from
6afc8af to
8d9782a
Compare
smklein
force-pushed
the
db_metadata_nexus_queries
branch
from
a91fb35 to
0a20282
Compare
smklein
force-pushed
the
db_metadata_nexus_handoff
branch
2 times, most recently
from
939eaf9 to
ed8c3b7
Compare
smklein
force-pushed
the
db_metadata_nexus_queries
branch
from
8e93726 to
2dba0e1
Compare
smklein
force-pushed
the
db_metadata_nexus_handoff
branch
4 times, most recently
from
c329ca8 to
ebaa6a2
Compare
smklein
force-pushed
the
db_metadata_nexus_handoff
branch
from
ebaa6a2 to
38a265b
Compare
davepacheco
approved these changes
Sep 3, 2025
| // Implementation function for attempt_handoff that runs within a | ||
| // transaction | ||
| // | ||
| // This function must be executed from a transaction context to be safe. |
There was a problem hiding this comment.
I guess there's no way to be sure that we're in one at compile-time?
There was a problem hiding this comment.
Not trivially - I could try to make some sorta "token" here - but this also isn't a public function, so IMO the risk of mis-use is pretty low.
smklein
added a commit
that referenced
this pull request
Sep 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split off of #8845
Adds and tests handoff-related queries which will be used in integration (reading on boot): #8925
Does not actually flip Nexus to use these records yet.
Depends on #8931
Next part of #8501: Adding queries for these records