switch zone shell prompt: pass api-version header via curl
#8975
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davepacheco
approved these changes
Sep 3, 2025
There was a problem hiding this comment.
The change itself is fine but I'm not sure how we want to deal with:
- this version may drift over time
- someone could break this API without realizing there's a bash consumer out there (nothing would break at CI-time)
Maybe the switch zone should ship a Rust binary using a Progenitor client that does this? This way:
- the program would automatically pick up new changes to the API
- things would break at build-time if the API were broken
ls-apiswould see this consumer
If that makes sense to you, maybe just file an issue about it for now? I think we could tag it good-first-issue.
It does! Filed #8976. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.