Skip to content

Conversation

papertigers
Copy link
Contributor

@papertigers papertigers commented Oct 20, 2025

This adds the SDS6BA138PSP9X3 nvme drive to sled-agent's
PREFERRED_NVME_DEVICE_SETTINGS hash map, additionally it shuffles some
logic around to always apply a 4K LBA data size to all devices as Robert
suggested in #8867

Fixes #8867

Created using jj-spr 1.3.6-beta.1
@papertigers papertigers requested a review from citrus-it October 20, 2025 20:04
Copy link
Contributor

@citrus-it citrus-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for restructuring and always attempting to find a 4kn namespace format.

@papertigers papertigers requested a review from citrus-it October 23, 2025 00:59
@papertigers
Copy link
Contributor Author

@citrus-it I added the is_oxide_sled() check like we discussed over chat if you could have a look again. Also cleaned up an unwrap while I was in the code.

Copy link
Contributor

@citrus-it citrus-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good. Just spotted one typo in a comment.

// Check that we are on real Oxide hardware so that we avoid:
// - Messing with NVMe devices in other environments
// - Failing tests which use zvols rather than real NVMe devices
// - Breaking virutal environments like a4x2 which likely don't expose or
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// - Breaking virutal environments like a4x2 which likely don't expose or
// - Breaking virtual environments like a4x2 which likely don't expose or

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Apply optimal drive settings for new drives

2 participants